Overhaul constexpr <cstdlib> and <cinttypes> - #6438
Open
Stephan T. Lavavej (StephanTLavavej) wants to merge 2 commits into
Open
Overhaul constexpr <cstdlib> and <cinttypes>#6438Stephan T. Lavavej (StephanTLavavej) wants to merge 2 commits into
constexpr <cstdlib> and <cinttypes>#6438Stephan T. Lavavej (StephanTLavavej) wants to merge 2 commits into
Conversation
…ypes.hpp` and `__msvc_stdlib.hpp`.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
September 5, 2026 19:17
Stephan T. Lavavej (StephanTLavavej)
added
enhancement
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Final Review
in STL Code Reviews
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Stephan T. Lavavej (StephanTLavavej)
September 5, 2026 19:18
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Mixed-mode linkage regression coverage is required for both headers.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
stl/inc/__msvc_inttypes.hpp — Please cover this linkage change with a mixed-translation-unit test that compiles <cinttypes>… |
|
stl/inc/__msvc_stdlib.hpp — Please add a mixed-translation-unit regression for this linkage change: compile one TU with… |
What changed in this PR
Updates constexpr <cstdlib> and <cinttypes> functions to prevent UCRT linker conflicts and improve debug-mode code generation.
Changes:
- Places definitions in C++ inline namespaces.
- Implements integer
abs()anddiv()overloads directly.
| File | Description |
|---|---|
stl/inc/__msvc_stdlib.hpp |
Updates abs() and div() linkage and implementations; needs a mixed-translation-unit /Zc:cmath regression test. |
stl/inc/__msvc_inttypes.hpp |
Updates imaxabs() and imaxdiv() linkage; needs a mixed-translation-unit /Zc:cmath regression test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6434.
extern "C++"inline namespacetechnique to__msvc_inttypes.hppand__msvc_stdlib.hpp.div().#pragma function" dance.abs()anddiv()overloads.